Skip to content

Conversation

@yomybaby
Copy link
Member

@yomybaby yomybaby commented Jul 10, 2025

TL;DR

Enhanced the Reservoir page with a new Audit Logs tab and improved the Artifacts tab with better filtering and visualization.

What changed?

  • Added a new ReservoirAuditLogList component to display audit logs for reservoir operations
  • Implemented tab navigation between Artifacts and Audit Logs using query parameters
  • Enhanced the ReservoirArtifactList component to use the BAITable component with neo styling and resizable columns
  • Added clickable statistic cards that filter artifacts based on their status
  • Improved filtering capabilities for both artifacts and audit logs
  • Added expandable rows in the audit logs to show detailed information
  • Created mock audit log data for demonstration purposes
  • Updated the UI to better visualize the current filter state with highlighted cards

How to test?

  1. Navigate to the Reservoir page
  2. Switch between the "Artifacts" and "Audit Logs" tabs
  3. Click on the statistic cards (Installed, Available, Currently Pulling) to filter artifacts
  4. Use the property filters to search for specific artifacts or audit logs
  5. Expand audit log rows to view detailed information
  6. Verify that pagination works correctly for both tabs
  7. Check that the UI state is preserved when switching between tabs

Why make this change?

This enhancement provides better visibility into reservoir operations through audit logs, allowing users to track when artifacts were pulled, installed, or modified. The improved filtering and visualization make it easier to manage a large number of artifacts and quickly find relevant information. The clickable statistic cards provide a more intuitive way to filter artifacts by status, improving the overall user experience.

@github-actions github-actions bot added the size:XL 500~ LoC label Jul 10, 2025
Copy link
Member Author

yomybaby commented Jul 10, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby force-pushed the feature/reservoir-audit-log-ui-draft branch 2 times, most recently from 1612eab to 4538cff Compare July 11, 2025 08:14
@yomybaby yomybaby force-pushed the feature/reservoir-audit-log-ui-draft branch from 4538cff to e7a1492 Compare August 14, 2025 01:57
@yomybaby yomybaby force-pushed the feature/reservoir-mockup-ui-detail-page branch from e52d727 to 6902094 Compare August 14, 2025 01:57
@github-actions
Copy link

github-actions bot commented Aug 14, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.47% (-0.02% 🔻)
501/11215
🔴 Branches
3.6% (-0.03% 🔻)
285/7909
🔴 Functions
2.58% (-0.01% 🔻)
90/3495
🔴 Lines
4.44% (-0.02% 🔻)
487/10964
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / ReservoirAuditLogList.tsx
0% 0% 0% 0%

Test suite run success

114 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from c43778b

@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 6902094 to d9c3b9f Compare August 18, 2025 01:15
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-audit-log-ui-draft branch from e7a1492 to d715fd0 Compare August 18, 2025 01:15
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from d9c3b9f to 1084697 Compare August 22, 2025 05:19
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-audit-log-ui-draft branch 2 times, most recently from 91a0d82 to aea9d8f Compare August 25, 2025 03:55
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 1084697 to 0b97860 Compare August 25, 2025 03:55
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-audit-log-ui-draft branch from aea9d8f to e29c8a7 Compare August 26, 2025 04:40
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 0b97860 to 01079f5 Compare August 26, 2025 04:40
@nowgnuesLee nowgnuesLee changed the base branch from feature/reservoir-mockup-ui-detail-page to graphite-base/3936 August 26, 2025 05:49
@nowgnuesLee nowgnuesLee changed the base branch from graphite-base/3936 to feature/reservoir-mockup-ui-detail-page August 26, 2025 07:11
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 01079f5 to 3df7a22 Compare August 26, 2025 08:33
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-audit-log-ui-draft branch from e29c8a7 to 3093243 Compare August 26, 2025 08:33
@yomybaby yomybaby force-pushed the feature/reservoir-mockup-ui-detail-page branch from 3df7a22 to 3dab197 Compare September 1, 2025 10:09
@yomybaby yomybaby force-pushed the feature/reservoir-audit-log-ui-draft branch from 3093243 to 6cd305d Compare September 1, 2025 10:09
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 3dab197 to 5c512ab Compare September 1, 2025 15:45
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-audit-log-ui-draft branch from 6cd305d to 3905acd Compare September 1, 2025 15:45
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-audit-log-ui-draft branch from 3905acd to 364a7f4 Compare September 2, 2025 02:33
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 5c512ab to f12e958 Compare September 2, 2025 02:33
@graphite-app graphite-app bot force-pushed the feature/reservoir-mockup-ui-detail-page branch 2 times, most recently from e2fc868 to be55c1b Compare September 3, 2025 03:02
@graphite-app graphite-app bot force-pushed the feature/reservoir-audit-log-ui-draft branch from 364a7f4 to 265ffc3 Compare September 3, 2025 03:02
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from be55c1b to 5b126ef Compare September 3, 2025 04:58
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-audit-log-ui-draft branch 2 times, most recently from 23dc32f to a8d60b5 Compare September 4, 2025 04:48
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 5b126ef to 5665f67 Compare September 4, 2025 04:48
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-audit-log-ui-draft branch from a8d60b5 to e45491e Compare September 9, 2025 03:45
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 5665f67 to 85b7ef4 Compare September 9, 2025 03:45
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-audit-log-ui-draft branch from e45491e to c5dd75a Compare September 10, 2025 07:14
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 85b7ef4 to 79ff6a3 Compare September 10, 2025 07:14
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-audit-log-ui-draft branch from c5dd75a to bdab7c3 Compare September 16, 2025 05:21
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 79ff6a3 to 3abc6f6 Compare September 16, 2025 05:21
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-audit-log-ui-draft branch from bdab7c3 to c55f576 Compare September 22, 2025 02:45
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 3abc6f6 to 12d80a9 Compare September 22, 2025 02:45
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 12d80a9 to dfe44d3 Compare September 22, 2025 11:22
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-audit-log-ui-draft branch from c55f576 to 08b00d9 Compare September 22, 2025 11:22
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-audit-log-ui-draft branch from 08b00d9 to c43778b Compare September 23, 2025 07:18
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from dfe44d3 to 65f4e59 Compare September 23, 2025 07:18
@yomybaby yomybaby closed this Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant